Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share threadpool configuration #110469

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Conversation

MichalStrehovsky
Copy link
Member

Threadpool can be configured using AppContext switches or environment variables. The environment variable configuration uses a roundabout mechanism that makes it CoreCLR specific. Move the configuration to managed code that is shared with all runtimes.

This should have equivalent behavior in less than half the lines of code unless I'm missing something.

Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@kouvel kouvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@MichalStrehovsky MichalStrehovsky merged commit 6362f24 into dotnet:main Dec 11, 2024
131 of 141 checks passed
@MichalStrehovsky MichalStrehovsky deleted the tpconfig branch December 11, 2024 06:14
hez2010 pushed a commit to hez2010/runtime that referenced this pull request Dec 14, 2024
Threadpool can be configured using AppContext switches or environment variables. The environment variable configuration uses a roundabout mechanism that makes it CoreCLR specific. Move the configuration to managed code that is shared with all runtimes.

This should have equivalent behavior in less than half the lines of code unless I'm missing something.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants